feat: Add Zarr v2 metadata access and basic auth support for OIDC-protected assets#2112
Draft
cauriol wants to merge 16 commits into
Draft
feat: Add Zarr v2 metadata access and basic auth support for OIDC-protected assets#2112cauriol wants to merge 16 commits into
cauriol wants to merge 16 commits into
Conversation
cauriol
changed the title
Contributor
Test Results 1 files - 3 1 suites - 3 33s ⏱️ - 3m 14s For more details on these failures, see this check. Results for commit d4f4729. ± Comparison against base commit 8c36c36. ♻️ This comment has been updated with latest results. |
Collaborator
|
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: 9faf04a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
|
Code Coverage (Windows)DetailsDiff against developResults for commit: 9faf04a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
cauriol
marked this pull request as ready for review
March 26, 2026 09:37
cauriol
marked this pull request as draft
April 1, 2026 09:27
cauriol
changed the title
Collaborator
|
@cauriol, instead of introducing a new method @sbrunato can we get your opinion here ? |
Collaborator
@alambare I agree. |
cauriol
force-pushed
the
auth_destinee
branch
2 times, most recently
from
April 2, 2026 12:57
141c247 to
ca62273
Compare
cauriol
marked this pull request as ready for review
April 2, 2026 13:36
alambare
requested changes
Apr 2, 2026
Comment on lines
+589
to
+595
| def request_asset( | ||
| self, | ||
| url: str, | ||
| ) -> requests.Response: | ||
| """Perform a GET request to the given URL using product's authentication headers.""" | ||
| headers = self.get_storage_options().get("headers", {}) | ||
| return requests.get(url, headers=headers, stream=True) |
Collaborator
There was a problem hiding this comment.
we should use the stream download method from EODAG download plugins instead of creating a new method.
cauriol
marked this pull request as draft
April 10, 2026 12:10
cauriol
marked this pull request as ready for review
April 13, 2026 07:46
sbrunato
requested changes
Jul 10, 2026
Collaborator
There was a problem hiding this comment.
get_storage_options implementation should be done in a separate PR
Comment on lines
+589
to
+595
| def request_asset( | ||
| self, | ||
| url: str, | ||
| ) -> requests.Response: | ||
| """Perform a GET request to the given URL using product's authentication headers.""" | ||
| headers = self.get_storage_options().get("headers", {}) | ||
| return requests.get(url, headers=headers, stream=True) |
| authentication_uri_source: login-form | ||
| --- | ||
| !provider # MARK: desp_cache | ||
| name: desp_cache |
Collaborator
There was a problem hiding this comment.
Provider name and description need to be updated. "Cache" does not seem appropriate in name and description.
Collaborator
There was a problem hiding this comment.
After further consideration I think we cannot add this provider in EODAG because it the data is in internal FDP which is not publicly exposed. But we can add the collections to the dedl provider and we should keep the changes for the auth plugin.
Collaborator
There was a problem hiding this comment.
Provider and its registration are not documented
sbrunato
marked this pull request as draft
July 10, 2026 10:27
Contributor
|
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: d4f4729 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Benchmark comparisonCompared baseline: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for accessing Zarr v2 assets from EOProduct and extends OIDC authentication handling to support Basic authorization for protected asset access.
Changes:
-add helper methods in EOProduct to:
- extract auth headers from auth objects
- request protected assets with forwarded authentication headers
- list files from Zarr v2 metadata using .zmetadata
Notes
this PR currently targets Zarr v2 only through .zmetadata
Zarr v3 support can be added later if needed